cody/wrestlingdev.com
1
0
Fork 0
mirror of https://github.com/jcwimer/wrestlingApp synced 2026-04-11 07:56:28 +00:00
Code Issues Releases Wiki Activity

Fixed bug in baumspage importer. Trailing (season loss) array item was shifted if it was blank.

Browse Source
This commit is contained in:
Jacob Cody Wimer
2019-01-10 19:22:42 +00:00
parent 31323593c9
commit 2516afd53c
2 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
app/services/school_services/baumspage_roster_import.rb
View File

@@ -28,7 +28,8 @@ class BaumspageRosterImport
def parse_starter(line) def parse_starter(line)
extra = false extra = false
wrestler_array = line.split(',') # ,-1 allows the last field in split to be blank
wrestler_array = line.split(',',-1)
wrestler_losses_array_spot = wrestler_array.size - 1 wrestler_losses_array_spot = wrestler_array.size - 1
wrestler_wins_array_spot = wrestler_array.size - 2 wrestler_wins_array_spot = wrestler_array.size - 2
last_criteria_array_spot = wrestler_wins_array_spot - 1 last_criteria_array_spot = wrestler_wins_array_spot - 1
@@ -43,15 +44,22 @@ class BaumspageRosterImport
def parse_extra(line) def parse_extra(line)
extra = true extra = true
wrestler_array = line.split(',') # ,-1 allows the last field in split to be blank
wrestler_array = line.split(',',-1)
wrestler_losses_array_spot = wrestler_array.size - 1 wrestler_losses_array_spot = wrestler_array.size - 1
wrestler_wins_array_spot = wrestler_array.size - 2 wrestler_wins_array_spot = wrestler_array.size - 2
if wrestler_array[1] if wrestler_array[1]
create_wrestler("#{wrestler_array[2]} #{wrestler_array[1]}", "#{wrestler_array[0]}", "", "#{wrestler_array[wrestler_wins_array_spot]}", "#{wrestler_array[wrestler_losses_array_spot]}",extra) create_wrestler("#{wrestler_array[2]} #{wrestler_array[1]}", "#{wrestler_array[0]}", "", "#{wrestler_array[wrestler_wins_array_spot]}", "#{wrestler_array[wrestler_losses_array_spot]}",extra)
end end
end end
def create_wrestler(name,weight,criteria,season_win,season_loss,extra) def create_wrestler(name,weight,criteria,season_win,season_loss,extra)
if season_win == ""
season_win = 0
end
if season_loss == ""
season_loss = 0
end
wrestler = Wrestler.new wrestler = Wrestler.new
wrestler.name = name wrestler.name = name
wrestler.school_id = @school.id wrestler.school_id = @school.id

3
test/integration/baumspage_importer_test.rb
View File

@@ -23,6 +23,9 @@ Some Guy
guy = @school.wrestlers.select{|w| w.name == "Another Guy"}.first guy = @school.wrestlers.select{|w| w.name == "Another Guy"}.first
assert guy.season_win == 5 assert guy.season_win == 5
assert guy.season_loss == 7 assert guy.season_loss == 7
guy5 = @school.wrestlers.select{|w| w.name == "Another Guy5"}.first
assert guy5.season_win == 0
assert guy5.season_loss == 0
end end
end end